feat: initial feature set #1
Conversation
There was a problem hiding this comment.
Holy moly, this is some complex stuff! I can mainly advise on the use of the polkadot api and on the typescript setup I think, both of which look good.
There are some features of the polkadot api you can make more use of to make the code a little less convoluted; I left suggestions that show that in some examples.
One more general thing you could look into is if it may be cool to have some functions available as custom derives as well, which could be quite elegant. Also derives work for both the rxjs-based api and the promise-based api (the latter of which we have always used), so may integrate better with other people's approaches. Unfortunately derives do not work where you need api connections to two different chains as far as I know; this is what CAPI was meant to solve. Really bummed out that they killed it, because this project right here is exactly the kind of thing you would want to be using it for...
| const relayParentBlockNumber = await providerApi | ||
| .at(providerBlockHash) | ||
| .then((api) => api.query.parachainSystem.lastRelayChainBlockNumber()) | ||
| const relayParentBlockHash = await relayApi.rpc.chain.getBlockHash( | ||
| relayParentBlockNumber, | ||
| ) |
There was a problem hiding this comment.
this would be so much nicer to implement on capi 😢
ntn-x2
force-pushed
the
aa/initial-setup
branch
from
0b801ec
to
3f8224b
Compare
Initial feature set. Integration tests will follow in a different PR. Code has been widely tested in many different scenarios via KILTprotocol/kilt-did-utilities#13, and ported here and adapted accordingly.