Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make_shared template #830

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add make_shared template #830

merged 3 commits into from
Feb 20, 2024

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Feb 2, 2024

No description provided.

@Montel Montel self-assigned this Feb 2, 2024
@LeonMatthesKDAB
Copy link
Collaborator

See: #823

LeonMatthesKDAB
LeonMatthesKDAB approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you tested this works as expected?

@LeonMatthesKDAB
Copy link
Collaborator

@Montel I think this can be merged now?

@ahayzen-kdab
Copy link
Collaborator

Once we have #843 I wonder if we move these into a cxx-qt header, so cxx-qt-common / cxx-qt

@Montel Montel enabled auto-merge (squash) February 20, 2024 13:15
@Montel Montel merged commit 04d4e79 into KDAB:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

@ahayzen-kdab ahayzen-kdab Awaiting requested review from ahayzen-kdab

Assignees

@Montel Montel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Montel @LeonMatthesKDAB @ahayzen-kdab