Restore obsolete l3_server port role for backward compatibility
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not used in `Create()` or `Update()` operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#428 eliminated the
l3_serverPort Role which existed in the API but has been removed from the Apstra GUI ages ago.As of 4.1.0, none of the baked-in Logical Devices or Interface Maps specify the
l3_serverport role, so it's likely only present if we (mistakenly) added it.This PR restores that Port Role to the
PortRolesenum along with:l3_serverinTestLogicalDevicePortRoles_SetAll()LogicalDevicePortRoles.Validate()which errors whenl3_serveris setLogicalDevicePortRoles.Validate()in Logical Device and Interface Map create/modify functionsThe goal is to ensure we can read/parse
l3_serverif it happens to be set on an existing object while ensuring that we never send (allow the user to set it) in future operations.Closes #432