Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: CirculatorySystemModels v0.3.1 #95784

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Nov 22, 2023

## Breaking changes since version 0.1.X:

1. The Double-Hill chamber `DHChamber` is now in terms of `dV/dt` rather than `dp/dt` which increases computation speed by an order of magnitude. The old form can be recovered using the `inP` argument. The parameter `Ev` has been removed. Please use the ventricular volume as an initial condition instead of the pressure. This can be calculated as $V = p/E_{min}$
2. `Compliance` and `Elastance` are now in terms of dV/dt. Use the new argument `inP=true` to recover the old form. Initial conditions need to be changed accordingly.
3. `Compliance` and `Elastance` have options for external pressure as parameter `has_ep` and as a connector pin to connect other pressures to `has_variable_ep` - the latter can take an equation like `C.ep.p ~ LV.p * K`.
4. Chamber has been deleted and replaced with `VariableCompliance` which can take a function for `E(t)` and has external pressure options like the other compliances and elastances.
5. `ShiChamber` already was formulated in terms of dV/dt. It now has the argument `inP=true` to allow the `dp/dt` form. Initial conditions need to be changed accordingly.

_*NOTE: the use of `inP` is strongly discouraged, since it needs the first derivative of the Elastance function, is less stable, and an order of magnitude slower. If you want to define initial condtions in pressure, it is advised to calculate the corresponding initial volume.*_

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@TS-CUBED
Copy link

TS-CUBED commented Nov 22, 2023

This seems to be a problem with NonLinearSolve if I read the stacktrace correctly?

Anything I can do?

[noblock]

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-circulatorysystemmodels-4211d73e-v0.3.1-16ca45172b branch from 13346d5 to 01baa65 Compare November 22, 2023 14:54
@github-actions github-actions bot added the stale label Dec 23, 2023
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-circulatorysystemmodels-4211d73e-v0.3.1-16ca45172b branch from 01baa65 to 2135504 Compare December 24, 2023 10:26
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-circulatorysystemmodels-4211d73e-v0.3.1-16ca45172b branch from 2135504 to c075899 Compare December 24, 2023 10:27
UUID: 4211d73e-f4e8-40c4-b600-92e4b82f0e1a
Repo: https://github.com/TS-CUBED/CirculatorySystemModels.jl.git
Tree: de472e62b5063f393a132bbf13ba246c2c5b2d3b

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-circulatorysystemmodels-4211d73e-v0.3.1-16ca45172b branch from c075899 to 8fdea01 Compare December 24, 2023 10:27
@JuliaTagBot JuliaTagBot merged commit 2ad9213 into master Dec 24, 2023
10 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-circulatorysystemmodels-4211d73e-v0.3.1-16ca45172b branch December 24, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants