Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: DotEnv2 v0.1.0 #32416

Closed
wants to merge 1 commit into from

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: e40d7179-d0e1-45c1-8aca-56c47694e472
Repo: https://github.com/Arkoniak/DotEnv2.jl.git
Tree: 36c65ac2f9ac3a0e2d7b7e59f668e4d62786f7ca

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch March 20, 2021 11:28 Inactive
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to DotEnv. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@Arkoniak
Copy link
Contributor

This is an updated fork of https://github.com/vmari/DotEnv.jl

Unfortunately, DotEnv.jl maintenance is too slow: tecosaur/DotEnv.jl#10, so I had to fork it. I am not sure, what are the rules on such close forks, it looked like it was ok to add a number on the end.

I can rename it, but unfortunately, DotEnv is the best name for this kind of package.

@fredrikekre
Copy link
Member

Thats unfortunate. @vmari if you don’t have time/resources to maintain this package would you be willing to give @Arkoniak some elevated permissions to help you out ? Alrernatively if you would be willing to transfer the repo to a GitHub organisation where more people can help out with maintenance? I don't know which org would fit though.

@Arkoniak
Copy link
Contributor

Can I recommend JuliaWeb organization? The most common use case I've encountered was related to the usage of some web services.

@Arkoniak
Copy link
Contributor

Arkoniak commented Mar 25, 2021

It's been almost a week (and more than 3 weeks from the initial PR to DotEnv.jl). @vmari is not responding either here or in direct mail. Can we proceed with registering this package? Or should I change the package name?

@fredrikekre
Copy link
Member

@vmari was at least active when merging tecosaur/DotEnv.jl#9 so not completely MIA. I just think it is unfortunate to merge this package, and then if @vmari answers in a week it will be deprecated.

Are you in a hurry to get this registered? It does not seem like a package you would have other packages depend on and thus can just add by URL for the time being?

We don't have a formal process for things like this yet, see #25367 for example.

@aviks
Copy link
Contributor

aviks commented Mar 25, 2021

My personal feeling is that we need to wait a few months rather than a few weeks before deprecating or transferring packages with missing maintainers. I feel that a few weeks is too strict for open source, volunteer maintained packages.

However, once again, this is open source, and we, of course, cannot, and should not prevent forking. But in the general case of forking, we should insist on much more differentiation in package names, to prevent confusion. My $0.02.

@Arkoniak
Copy link
Contributor

I cannot completely agree with this statement. We have packages like JSON.jl, JSON2.jl and JSON3.jl in Julia ecosystem, so it's not quite clear why DotEnv2.jl is not allowed. If the policy of forbidding number suffixes in package names is accepted, then all such packages should be renamed, otherwise it seems that package authors are divided in first- and second- class citizens, where first has more privileges than the others.

Anyway, this current package is not worth the time, that was spent already. I have opened a new PR with another package name.

So

  1. Can we close this PR.
  2. Can somebody merge New package: ConfigEnv v0.1.0 #32797? I know, that it will be merged automatically after 3 days, but can I have at least this small favor?

@vmari
Copy link

vmari commented Mar 25, 2021

Hi guys. Sorry for missing this. I've been working nonstop and just now have time to take this.
I'm open to add you @Arkoniak as mantainer if you agree. I'm on it.

@aviks
Copy link
Contributor

aviks commented Mar 25, 2021

@Arkoniak JSON2 was developed by the explicit goal of replacing JSON2, (I know, since I was the original author of JSON). JSON3 was done by the same person who did JSON3. But even then, in retrospect, we shouldnt have done that. Today, that would have been caught by our new automated checks.

However, I'll say it again, forking is fine, and a fundamental right in open source. However, as our community grows, we have to be stricter, not more linient, when it comes to naming issues.

@fredrikekre
Copy link
Member

Looks like this has been resolved (#32806, #32811).

@giordano giordano deleted the registrator/dotenv2/e40d7179/v0.1.0 branch March 25, 2021 15:10
@Arkoniak
Copy link
Contributor

Arkoniak commented Mar 25, 2021

Sorry, at this point I have to decline the offer. I rewrote original package two times already, I am kind of attached to a new name and I already changed some of my applications to use it. I will open a new PR, please do not close it. I am ready to wait 3 days, just don't do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants