more small changes for trimming #55255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jul 26, 2024
base/libuv.jl
Outdated
Comment on lines
136
to
137
| reinit_stdio() = _reinit_stdio() | ||
| function _reinit_stdio() |
There was a problem hiding this comment.
What in the world does this do?
There was a problem hiding this comment.
Well, this PR is about "more small changes for trimming" -- and this adds a change we can later trim? 🤔 😂
There was a problem hiding this comment.
Ah, I think we did this at one point so we could disable Base's call to it, but still be able to easily call it ourselves later. But it looks like we don't need this anymore.
JeffBezanson
force-pushed
the
jb/trimmingmisc
branch
from
b410691
to
9abf6f0
Compare
vtjnash
approved these changes
Jul 26, 2024
JeffBezanson
force-pushed
the
jb/trimmingmisc
branch
from
9abf6f0
to
b0c2281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more unobjectionable, NFC changes from #55047.