Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots tutorial [now with extra Makie bonus content] #20

Closed
wants to merge 1 commit into from

Conversation

aoanla
Copy link
Collaborator

@aoanla aoanla commented Nov 3, 2023

Hello all,

This is the current version of the plots tutorial, which goes a little fast [and could probably be even faster]. I added 1 Makie and 1 AlgebraOfGraphics example at the end just so people can see them being used for something, but there's no actually tutorialising in those parts.

I also made 1 edit to the Broadcasting tutorial to mention that broadcasting over a row and a column vector does the outer product, as I use it here and also in another case to make a quick matrix.

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023

As far as I can tell, the deploy-book is failing because it runs as "me", and I don't have edit perms on the base repo here.

@graeme-a-stewart
Copy link
Member

As far as I can tell, the deploy-book is failing because it runs as "me", and I don't have edit perms on the base repo here.

I just gave you maintain rights...

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023

Hm, I have no idea why this is still failing (for you and me) - "Resource not accessible by integration" usually means that there's a permissions issue somewhere.... but this is on the deploy part that should be trivial (it's not when the book is actually built)

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023

Aha, I see the problem, the "deploy preview" action is https://github.com/rossjrw/pr-preview-action which explicitly notes "This Action does not currently support deploying previews for PRs from forks, but will do so in rossjrw/pr-preview-action#6." Since this is a PR from a fork...

Now I have maintain rights here, though, I can probably push this branch into a branch of this main repo, and then make a pull request for that (which should work with this action).

@Moelf
Copy link
Member

Moelf commented Nov 3, 2023

well don't worry you can probably just merge this and we will see

@aoanla aoanla mentioned this pull request Nov 3, 2023
@aoanla aoanla closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants