implement DelayQueue
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is hitting a code-coverage miscalculation bug in ResumableFunctions: JuliaDynamics/ResumableFunctions.jl#46 That is why the code coverage looks like it has declined when it is actually tested. |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 98.67% 97.15% -1.53%
==========================================
Files 11 12 +1
Lines 302 316 +14
==========================================
+ Hits 298 307 +9
- Misses 4 9 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I have started working on fixing the code coverage issue in JuliaDynamics/ResumableFunctions.jl#71 More needs to be done in I will not consider this a blocking issue for this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the example already given in the documentation
I would like to finish this PR before I deal with #94 as this is an important edge case to get correctly.