feat(ref:#122): now with eslint9

JsDaddy · May 30, 2024 · afc4c47 · afc4c47
2 parents f77c225 + e176eba
commit afc4c47
Show file tree

Hide file tree

Showing 11 changed files with 28,232 additions and 28,292 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -9,11 +9,11 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
-          registry-url: https://registry.npmjs.org/
+          node-version: 20
+
       - name: Build library
         run: |
             npm ci --force
@@ -69,4 +69,4 @@ jobs:
                           ]
                         }
                 env:
-                    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+                    SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
diff --git a/.github/workflows/quality-check.yml b/.github/workflows/quality-check.yml
@@ -17,10 +17,10 @@ jobs:
     permissions:
       contents: write
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
       - name: Check quality
         run: |
           npm ci --force

diff --git a/cypress/support/component.ts b/cypress/support/component.ts
@@ -28,7 +28,7 @@ import { mount } from 'cypress/angular';
 declare global {
     // eslint-disable-next-line @typescript-eslint/no-namespace
     namespace Cypress {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
+         
         interface Chainable {
             mount: typeof mount;
         }

diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,98 @@
+// @ts-check
+const globals = require('globals');
+// Allows us to bring in the recommended core rules from eslint itself
+const eslint = require('@eslint/js');
+
+// Allows us to use the typed utility for our config, and to bring in the recommended rules for TypeScript projects from typescript-eslint
+const tseslint = require('typescript-eslint');
+
+// Allows us to bring in the recommended rules for Angular projects from angular-eslint
+const angular = require('angular-eslint');
+
+const json = require('eslint-plugin-json');
+
+const ignores = [
+    'dist/',
+    'tmp/',
+    'out-tsc/',
+    'bazel-out/',
+    'node_modules/',
+    '.idea/',
+    '.vscode/',
+    '.history/',
+    '.angular/',
+    'coverage/',
+    'coverage-ts/',
+    'package-lock.json',
+];
+
+// Export our config array, which is composed together thanks to the typed utility function from typescript-eslint
+module.exports = tseslint.config(
+    {
+        ignores,
+    },
+    {
+        // Everything in this config object targets our TypeScript files (Components, Directives, Pipes etc)
+        files: ['**/*.ts'],
+        extends: [
+            // Apply the recommended core rules
+            eslint.configs.recommended,
+            // Apply the recommended TypeScript rules
+            ...tseslint.configs.recommended,
+            // Optionally apply stylistic rules from typescript-eslint that improve code consistency
+            ...tseslint.configs.stylistic,
+            // Apply the recommended Angular rules
+            ...angular.configs.tsRecommended,
+        ],
+        // Set the custom processor which will allow us to have our inline Component templates extracted
+        // and treated as if they are HTML files (and therefore have the .html config below applied to them)
+        processor: angular.processInlineTemplates,
+        // Override specific rules for TypeScript files (these will take priority over the extended configs above)
+        rules: {
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: ["ngxCopyPaste", "jsdaddy"],
+                    style: 'camelCase',
+                },
+            ],
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'jsdaddy',
+                    style: 'kebab-case',
+                },
+            ],
+        },
+    },
+    {
+        // Everything in this config object targets our HTML files (external templates,
+        // and inline templates as long as we have the `processor` set on our TypeScript config above)
+        files: ['**/*.html'],
+        extends: [
+            // Apply the recommended Angular template rules
+            ...angular.configs.templateRecommended,
+            // Apply the Angular template rules which focus on accessibility of our apps
+            ...angular.configs.templateAccessibility,
+        ],
+        rules: {},
+    },
+    {
+        files: ['**/*.js'],
+        extends: [eslint.configs.recommended],
+        languageOptions: {
+            sourceType: 'commonjs',
+            globals: {
+                ...globals.node,
+            },
+        },
+        rules: {},
+    },
+    {
+        files: ['**/*.json'],
+        extends: [json.configs.recommended],
+        rules: {},
+    }
+);