Docker-Compose no more #5190
Merged
Docker-Compose no more #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mnaamani you missed the README.md of the QN |
freakstatic
suggested changes
Sep 18, 2024
| ln -s /usr/local/bin/docker-compose /usr/bin/docker-compose | ||
| " | ||
| creates: /usr/local/bin/docker-compose | ||
| # - name: Install docker-compose |
There was a problem hiding this comment.
this part can probably be removed
| @@ -43,7 +43,6 @@ | |||
| - docker-compose | |||
There was a problem hiding this comment.
I think this line is no longer needed
There was a problem hiding this comment.
This Ansible task will actually uninstall docker-compose. See the later line state: absent so the apt module will remove it if found.
There was a problem hiding this comment.
Oh I see, makes sense then 👍
freakstatic
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all scripts, docs and automation to not install or use
docker-compose, replaced withdocker composecommand. It is no longer recommended, and it is not found on the github runners so some github workflows are failing.