-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance qa evaluation #823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakravarthik27
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two categories of distance metrics: Embedding Distance Metrics and String Distance Metrics, enhancing the capabilities of the library for comparing embeddings and strings.
Notebook
Distance Metrics for Comparing Embeddings
String Distance Metrics
Impact
Results:
Type of change
Usage
Configuration Structure
To configure your embedding models and evaluation metrics, you can use a YAML configuration file. The configuration structure includes:
model_parameters
specifying model-related settings.evaluation
setting the evaluationmetric
,distance
, andthreshold
.embeddings
allowing you to choose the embeddingmodel
andhub
.tests
defining different test scenarios and theirmin_pass_rate
.Here's an example of the configuration structure:
Checklist:
pydantic
for typing when/where necessary.