Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): add subjectAltName field into self signed certificate #1429

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Oct 23, 2023

  1. add subjectAltName field into self signed certificate

    Current install script only fills CN field with PUBLIC_HOST value. When
    trying to access api and provide the self signed certificate to verify
    server certificate, the request will fail with SSL:
    CERTIFICATE_VERIFY_FAILED error.
    
    To prevent this error, the install script should add "subjectAltName =
    IP.1:${PUBLIC_HOST}" when generating self signed certificate.
    
    ```python
    import requests
    requests.get('https://${API_PREFIX}/access-keys',verify='shadowbox-selfsigned.crt')
    ```
    zouxifeng committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    047afbc View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. add hostname into the self signed certificate use IP or DNS in SAN field

    Use a regex to test whether input hostname is an IP address. If it's an
    IP address, use "IP" prefix. Otherwise, use "DNS".
    zouxifeng committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    eb766eb View commit details
    Browse the repository at this point in the history