Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build upgrade for aarch64/arm64 architecture #1399

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

cleardevice
Copy link
Contributor

No description provided.

@cleardevice cleardevice requested review from fortuna and a team as code owners September 4, 2023 17:17
@google-cla
Copy link

google-cla bot commented Sep 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Code mostly look good, and you clearly understand the problem. We need a few tweaks to make it a bit cleaner and make sure we don't use the same path for different architectures.

src/shadowbox/docker/build.action.sh Outdated Show resolved Hide resolved
third_party/prometheus/Makefile Outdated Show resolved Hide resolved
third_party/outline-ss-server/Makefile Outdated Show resolved Hide resolved
third_party/outline-ss-server/Makefile Outdated Show resolved Hide resolved
third_party/outline-ss-server/Makefile Outdated Show resolved Hide resolved
@MuhmdRaouf
Copy link

Any news about this PR mates ?

@cleardevice
Copy link
Contributor Author

Any news about this PR mates ?

Good question. I implemented everything that was needed for it

@daniellacosse
Copy link
Contributor

@fortuna

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This looks great!

@fortuna fortuna changed the title Build upgrade for aarch64/arm64 architecture feat: build upgrade for aarch64/arm64 architecture Sep 28, 2023
@cleardevice
Copy link
Contributor Author

Thanks for the contribution. This looks great!

Please, approve changes again. I fixed the crashed build

@fortuna
Copy link
Collaborator

fortuna commented Sep 28, 2023

@cleardevice any idea why the Shadowbox test is failing? Does it fail in your machine as well?

@cleardevice
Copy link
Contributor Author

@cleardevice any idea why the Shadowbox test is failing? Does it fail in your machine as well?

It was a DockerHub problem. Everything should be fine now

@MuhmdRaouf
Copy link

So since all the checks have passed, should we expect soon a new release that supports ARM machines?

TBH, I really don't like that we rely on 3rd party images in order to get Outline working.

thanks for your hard work mate 🙏🏼

@fortuna fortuna merged commit 4716680 into Jigsaw-Code:master Sep 29, 2023
12 checks passed
@fortuna
Copy link
Collaborator

fortuna commented Sep 29, 2023

Thanks for the contribution. It's now merged. I'll try to release in the next few weeks. I don't really know how to release multi-arch docker images, so I'll need to figure that out.

@cleardevice cleardevice deleted the aarch64 branch September 29, 2023 15:18
@cleardevice
Copy link
Contributor Author

TBH, I really don't like that we rely on 3rd party images in order to get Outline working.

This is the main reason for this changes. Using Outline for security, we shouldn't trust 3rd party images. Otherwise, what kind of zero trust can we talk about?
Before we will get official images you can use my:

sudo bash -c "SB_IMAGE=cleardevice/outline-server:latest $(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server.sh | sed 's/x86_64/aarch64/g')"

or build personal one and use it from own DockerHub:

git clone https://github.com/Jigsaw-Code/outline-server.git
cd outline-server
ARCH=arm64 bash ./scripts/run_action.sh shadowbox/docker/build

Feel free to contact me if you have any problems with build or launch.

@cleardevice cleardevice restored the aarch64 branch October 21, 2023 19:46
@cleardevice
Copy link
Contributor Author

Thanks for the contribution. It's now merged. I'll try to release in the next few weeks. I don't really know how to release multi-arch docker images, so I'll need to figure that out.

I'm glad that my contribution is useful to the community.

Now we can build 4 images: Linux (x86_64, Arm64) and macOS-Darwin (x86_64, Arm64).
All you need to build is the corresponding operating system image: Linux and Mac OS with the docker installed.

Feel free to contact me if you need help with building an image or CI customization.

@MuhmdRaouf
Copy link

Hello Mates,
Just was curious if this is still in the planning for the next release

Thanks for your hard work 🙏🏼

@daniellacosse
Copy link
Contributor

Hey - it should be released in the new version, when that happens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants