-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(manager): centralize list of server files #1233
base: master
Are you sure you want to change the base?
Conversation
declare -a openssl_req_flags=( | ||
-x509 -nodes -days 36500 -newkey rsa:4096 | ||
-subj "/CN=${PUBLIC_HOSTNAME}" | ||
-keyout "${SB_PRIVATE_KEY_FILE}" -out "${SB_CERTIFICATE_FILE}" | ||
-keyout "${PRIVATE_KEY_FILE}" -out "${CERTIFICATE_FILE}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these file contents or file paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe worth renaming to CERTIFICATE_FILEPATH
?
This is an attempt to document and clarify all the files we have on the server persistence layer.