-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various search related fixes #883
Various search related fixes #883
Conversation
Fixes VIM-3257
Regression while migrating to the new regex engine removed the highlights shown when confirming each change
Fixes VIM-2779
Fixes VIM-2174
Fixes VIM-3325
Setting 'incsearch' and 'nohlsearch' should highlight only the current match in the current editor
Search motion type should be linewise if there's a line offset, or inclusive if the `e` flag is provided. Otherwise, it's exclusive. Fixes VIM-1940
Fixes VIM-2356
Fixes VIM-3293
Fixes VIM-3391
Fixes VIM-3354
This is a messy quick fix, as the search group needs a lot of tidying up right now. Perhaps a better implementation would be to move the implementation of the global command into the search group - processGlobalCommand, like we already have processSearchCommand and processSubstituteCommand Fixes VIM-3348
Fixes VIM-698
Fixes VIM-2141
Fixes VIM-2888
Fixes VIM-2836
Substitute always works on a known range
Fixes VIM-1043
Also implements <C-L> to "redraw" screen and clear status line
Fixes VIM-3344
Fixes VIM-2510
When performing a substitute command with confirmation, the height of the editor content pane should be reduced by the height of the ex entry panel. IdeaVim would do this correctly when moving a search result to the bottom of the file, but not when the result was on the last line of the file. Because the wrong height was used, IdeaVim would decide that no scrolling was necessary and the result in the last line would be obscured. Fixes VIM-1560
Fixes VIM-3028
Fixes VIM-3428
a06c960
to
ca48731
Compare
Thank you for all the great updates and fixes! I have only one question about the first commit. Are you sure that using |
I guess it is a little bit of a fudge, but it's not one I'm too bothered about. The override mechanism is there to modify behaviour, although the main use case is mapping to an external IDE setting, so I'm ok with it being used to change the behaviour of change notifications. The boolean returned from What is interesting is that I didn't realise that E.g.:
|
Wow, I didn't know about |
This PR fixes various search related issues.
Search highlights:
:set hlsearch
not re-enabling highlights after:nohlsearch
(VIM-3257):substitute/{pattern}/{string}/c
command'incsearch'
and'nohlsearch'
adding highlights to other windows. It should only highlight the current match in the current editor to match Vim's behaviour'ignorecase'
for search highlights, ignoring passed in case sensitivity atom (VIM-3391)Incremental search:
Search behaviour:
[count]/
in search (VIM-2836)e
flag. Default motion is exclusive. Providing thee
flag changes it to inclusive, and an offset makes it linewise (VIM-1940)//e
now works (VIM-2356):%s/foo/~
would use the last substitution string, but also reset it to an empty string. It's now only reset when it's a value other than~
(VIM-3354)/e
flag to navigate to end of search result (VIM-3344)\%$
) (VIM-2888)Misc:
/
or:
commands not registering if ex entry is cancelled by losing focus (VIM-3293)