-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VIM-1503]Adding option to "fix" the usability problem involving international keyboards and dead keys. #847
Conversation
Thanks for the PR! I'm not entirely sure what it's doing - could you give some scenarios (inserting text, motions, etc.) and how it fixes the problems, please? |
Hey @citizenmatt, sure! I'll try to explain: val test = "Lorem ipsum do*lor sit amet"
// For some reason, if I try to select the entire sentence using the 'vi"' command,
// it erases the character under the cursor and then selects the sentence.
// In the example above, the letter 'o' will be erased.
val test = "*Lorem ipsum dlor sit amet*" The code in this PR, tries to keep track of what "text" is under the cursor in the moment that an action is being executed. Thats what the val test = "Lorem ipsum do*lor sit amet"
// Now when I try to select the entire sentence using the 'vi"' command,
// it selects the entire sentence correctly.
val test = "*Lorem ipsum dolor sit amet*" |
Hey @citizenmatt, @AlexPl292.. Is this PR missing something to be reviewed? I don't mean to be annoying or demand anything, but this issue is really annoying for my workflow. |
Hi Bruno. Apologies for the silence - there's not much bandwidth to look at stuff right now. Thanks for the contribution, but I must admit that I have a few reservations with this approach. I tried it locally, and after enabling My main issue is that this is a workaround for a specific problem, rather than fixing the root cause. So it means that This approach would require further investigation though, possibly using There are simpler workarounds, though, such as using a different keymap, if possible. The ABC keymap on the Mac doesn't have dead keys for the quote symbols, and something like Ukulele can create new keymaps that don't have any dead keys. Thanks again for the contribution. I'll leave it up to @AlexPl292 to decide what to do with this PR as it stands. It might be worth taking on as a workaround until someone can take a look at other Swing based implementations (invitation is open to all! 😁) |
Hey @citizenmatt thanks for the reply! I understand that this is a "hacky" solution, and you guys may have reservations against merging this PR(no hard feelings). About the need to press the extra key |
Hi there. Sorry, but I can't accept this PR. In addition to Matts response, I don't like adding new options for fixes like that. The problem is almost no one knows about such options, and they contribute to combinations under which IdeaVim may work, so it starts to be more complicated to make sure everything is properly tested. I agree that pressing "space" after In IJ, the initial
Not sure how this should be fixed, but I think we need a more common approach. Thank you for your interest in the question, though! |
Hi! First time contributing here. Please tell me if something could have been done better and I'll try to fix it.
Trying to fix this error: https://youtrack.jetbrains.com/issue/VIM-1503
The best that I could think of was to create an option for those that use this types of keyboard.