Fleet #846
Fleet #846
Conversation
This reverts commit 00ccddf.
The newer implementation is a part of the vim-engine library and uses new methods from the SearchGroup.kt, but it is not fully refactored yet
The more methods we have in the engine, the fewer number of methods we will need to implement in the Fleet
Pasting was broken with immutable carets because the old caret was not updated during execution
There was a problem hiding this comment.
A lot of functions in the SearchGroup have no usages in the code. The reason for that is actually stored in the master commit 06e1af3.
The combination of unused code + "revert of revert" significantly slows down the speed of the review as I have to spend more time understanding what changed and the reason behind the change.
In addition, the unused code by itself also leads to the slow down of the review as I have to review this unnecessary code plus understand why there are no usages. And since we have a code quality tool, this will cause extra unnecessary reports from it.
Please handle the comment about the VimPsiService naming in future pull requests.
|
|
||
| import com.maddyhome.idea.vim.common.TextRange | ||
|
|
||
| public interface VimPsiService { |
There was a problem hiding this comment.
PSI is an intellij-specific term. As vim-engine is unbound from intellij, this would be better not to use such terms as well.
Inside of IntelliJ IDEA, use of PSI is a more implementation-specific thing. Looking at the methods of this class, it seems that it answers the questions about the language syntax, so probably VimLanguageSyntaxService?
No description provided.