Only notify option change to initialised editors #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes VIM-3256
The fact that these methods only return local editors (i.e., editors for the local user while hosting a Code With Me session) is an implementation detail
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that IdeaVim only works with editors that have been initialised. This is important for various callbacks, such as notifications when setting editor options.
For example, the
~/.ideavimrcfile is evaluated during startup, before other editors are initialised. It can set various option values which in turn notify all affected editors. If the IDE opens editors at startup, these editors would be notified of changes before they've been initialised. VIM-3256 is an example of an issue caused by this - the uninitialised editors are notified, and try to check local-to-buffer options. These local-to-buffer options haven't yet been initialised, but trying to get a value will create the storage map for them, without setting any values. Subsequent attempts to use local-to-buffer options (such as'keyword') can result in an assert.