Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clip interop views whose clipped and unclipped bounding boxes don't match #1430

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

elijah-semyonov
Copy link

Perform masking on interop views, whose clipped and unclipped bounding boxes don't match.

Before:

before_fix.mov

After:

after_fix.mov

Release Notes

iOS - Fixes

  • Interop views are now correctly clipped when their measured clipped and unclipped bounding boxes don't match

@elijah-semyonov elijah-semyonov self-assigned this Jul 3, 2024
@elijah-semyonov elijah-semyonov changed the title Perform masking on interop views, whose clipped and unclipped global bounds don't match Perform masking on interop views, whose clipped and unclipped bounding boxes don't match Jul 3, 2024
@elijah-semyonov elijah-semyonov marked this pull request as draft July 3, 2024 16:28
@elijah-semyonov
Copy link
Author

@ASalavei proposed to clip using interopView itself, seems like a better idea

@elijah-semyonov elijah-semyonov marked this pull request as ready for review July 9, 2024 08:30
@elijah-semyonov elijah-semyonov changed the title Perform masking on interop views, whose clipped and unclipped bounding boxes don't match Properly clip interop views whose clipped and unclipped bounding boxes don't match Jul 9, 2024
@elijah-semyonov elijah-semyonov merged commit 26b4dee into jb-main Jul 9, 2024
6 checks passed
@elijah-semyonov elijah-semyonov deleted the es/interop-view-clipping branch July 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants