Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error logging when a char or service is missing #142

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Aug 9, 2022

Trying to work out #135

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #142 (bf84dba) into main (652b55f) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   70.87%   70.78%   -0.09%     
==========================================
  Files          70       70              
  Lines        5833     5840       +7     
==========================================
  Hits         4134     4134              
- Misses       1699     1706       +7     
Flag Coverage Δ
unittests 70.78% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohomekit/controller/ble/bleak.py 37.50% <0.00%> (-7.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdraco bdraco marked this pull request as ready for review August 11, 2022 20:04
@bdraco
Copy link
Collaborator Author

bdraco commented Aug 11, 2022

I haven't had any luck with #135 since the problem is deep in the bluez stack. The improved logging will help us tell if other vendors are affected, but at this point it seems limited to just one vendor

@bdraco bdraco merged commit dfce1a7 into main Aug 11, 2022
@Jc2k Jc2k deleted the improve_logging_when_char_service_missing branch July 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants