Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check citations command to see unused cites #4384

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

buehler
Copy link

@buehler buehler commented Sep 13, 2024

Hi there :-)

I really like using your extension and thought to add a new command
for BibTeX files. It would be very cool to have this inserted into the
workshop extension.

This PR adds a new command to the action-bar under the bibtex
category. It allows people to use the "checkcites" command line tool
that is shipped with recent Tex installations. The user then sees
a list of unused citations and can directly jump to them.

As such, you can cleanup your citations at the end of your paper.

I know that I still need to provide translations. Do I need to do them for all
languages? Because I'll not be able to do that.

I'll open this PR as a draft until I know how to proceed.

@James-Yu
Copy link
Owner

Thank you for your contribution. If I understand correctly, this feature is somewhat of the same kind with lw.extra.counter right? These features should reside in src/extra and have minimal code injections in other source files, in order to be maintainable.

I agree that files in extra/ are not quite minimally intrusive at their current state. However, new standalone features need to be as "sneaky" as possible.

@buehler
Copy link
Author

buehler commented Sep 16, 2024

fair enough :) I'll rearrange stuff according to your guidelines

@buehler
Copy link
Author

buehler commented Sep 16, 2024

Is it ok, if the command stays inside the bibtex section in the action bar? It is related to bibliography and as such it makes sense to keep it there.

I change the files to be in extra.

@James-Yu
Copy link
Owner

Thanks for the changes. There is one minor thing before the next step: there are unnecessary changes in linter.ts. Please revert.

In the meantime, I am still considering how to better arrange the extra/ features. It is more an architectural design, and any final thought won't require you to make additional changes. Just maybe some more time before I confirm my thoughts and merge.

@buehler
Copy link
Author

buehler commented Sep 28, 2024

I just checked, linter.ts has no changes in it (according to the changed files tab)

@buehler buehler marked this pull request as ready for review September 28, 2024 07:57
@buehler
Copy link
Author

buehler commented Sep 28, 2024

ah, I get it, you mean src/lint/index.ts

@buehler
Copy link
Author

buehler commented Sep 28, 2024

Reverted the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants