Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator async #88

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

ball6847
Copy link

As requested in #87 . I've cleaned up my branch and add more detail in README.

Not sure if writing tests is neccessary since this feature depends on angular's $asyncValidators.

Thanks,
Porawit Poboonma

@Jakobovski
Copy link
Owner

This looks great. Thanks for the hard work!

A few small changes are needed before I merge:

  1. Remove the first line from the readme
  2. Update the version in bower.json and tag the repo with the new version.
  3. Create a new plunkr with the updated code, and update the link in the readme to the plunkr.

Cheers.

@Jakobovski
Copy link
Owner

Hey any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants