Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skyline syntax (preferring clause) #2078

Merged

Conversation

ssteinhauser
Copy link
Contributor

This PR implements the skyline syntax (preferring clause) of Exasol which is available for SELECT, UPDATE and DELETE statements. For more details see https://docs.exasol.com/db/latest/advanced_analytics/skyline.htm

@ssteinhauser ssteinhauser marked this pull request as draft September 16, 2024 07:37
@ssteinhauser ssteinhauser marked this pull request as ready for review September 16, 2024 08:03
@manticore-projects
Copy link
Contributor

Thank you much for your contribution and effort!
Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

Copy link
Contributor

@manticore-projects manticore-projects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no wild card imports (as requested by @wumpz).
Rest looks great as usual and I would merge immediately when this will have been cleaned up. Thanks!

@manticore-projects
Copy link
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

@ssteinhauser
Copy link
Contributor Author

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol.
So a 5.1 release might make sense then.

@ssteinhauser
Copy link
Contributor Author

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.

@manticore-projects manticore-projects merged commit d1373c5 into JSQLParser:master Sep 17, 2024
2 checks passed
@manticore-projects
Copy link
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.

there should be a configuration for this (even project specific).

@ssteinhauser ssteinhauser deleted the feature/skyline-syntax branch September 17, 2024 09:32
@manticore-projects
Copy link
Contributor

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol. So a 5.1 release might make sense then.

Ok, so I would like to suggest we will wait with 5.1 for this specific stuff and then will aim for a release when this would be ready.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants