-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor bkgerrstddev into a saber block #1085
Open
travissluka
wants to merge
21
commits into
develop
Choose a base branch
from
feature/refactor_bkgerrstddev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the existing
BkgErrGodas
linear variable change into aParametricOceanStdDev
saber block (that lives in the SOCA repo for now), written in C++Why?
diffusion
, I'll save moving it out of SOCA for a later PR (once we're sure it works as intended and is indeed generic)oops::Diffusion
class to smooth the resulting stddev by the length scales. Much less noisy now (see images below), the scales by which the fields are smoothed can be configured. Unlike with the correlation operator, no offline parameters need to be calculated to use the smoothing (since there is no normalization)Also,
Usage:
The saber block has reasonable default values set (in an effort to keep outside collaborators from trying to do crazy things), so, for example you could use a minimum yaml such as
this will still enable the smoothing by default.
Or, if you want to set parameters explicitly, see what is given in the
testinput/dirac_parametric_ocean_stddev.yml
file, or look at the parameters class insrc/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.h
(real documentation will be coming, I promise!)Testing
This is the T bkg error at lvl 15 (very noisy
Same level but with this new saber block, where the stddev is smoothed by the Rossby radius