Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-7186] updates embedded manager calls #645

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[MOB-7186] updates embedded manager calls #645

merged 1 commit into from
Oct 24, 2023

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Oct 17, 2023 •
edited by jira bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request updates the embedded session manager to a private property with an associated getter. Also, renames embeddedManager() to getEmbeddedManager().

Ayyanchira
Ayyanchira approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evantk91 evantk91 merged commit 10d9586 into embedded Oct 24, 2023
3 of 4 checks passed
@evantk91 evantk91 deleted the evan/MOB-7186-updating-embedded-manager-calls branch October 24, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @Ayyanchira