Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #612

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Fix CI #612

merged 7 commits into from
Oct 16, 2023

Conversation

vbabenkoru
Copy link
Contributor

@vbabenkoru vbabenkoru commented Aug 1, 2023

🔹 Jira Ticket(s) if any

✏️ Description

Fix CI on the encryption branch.

“Akshay added 4 commits October 5, 2023 16:34
Adding security overrides so that CI doesn't fail on minSDK version due to crypto library.
1. Adding security override on api-ui
2. Adding compileOptions in api-build.gradle file. Although seems like a repitition as app - build.gradle has it already
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (122badb) 62.16% compared to head (f8f1488) 61.93%.
Report is 192 commits behind head on encryption.

❗ Current head f8f1488 differs from pull request most recent head 06d283e. Consider uploading reports for the commit 06d283e to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           encryption     #612      +/-   ##
==============================================
- Coverage       62.16%   61.93%   -0.24%     
==============================================
  Files              67       70       +3     
  Lines            3933     4124     +191     
  Branches          454      481      +27     
==============================================
+ Hits             2445     2554     +109     
- Misses           1249     1309      +60     
- Partials          239      261      +22     
Files Coverage Δ
...le/iterableapi/ui/inbox/IterableInboxFragment.java 83.78% <100.00%> (ø)
...va/com/iterable/iterableapi/IterableConstants.java 0.00% <ø> (ø)
...a/com/iterable/iterableapi/IterableDataRegion.java 100.00% <100.00%> (ø)
...rable/iterableapi/IterableNotificationBuilder.java 83.92% <100.00%> (+0.29%) ⬆️
...able/iterableapi/IterablePushNotificationUtil.java 76.31% <ø> (ø)
...java/com/iterable/iterableapi/IterableWebView.java 0.00% <ø> (ø)
.../iterable/iterableapi/IterableActivityMonitor.java 93.44% <0.00%> (-0.21%) ⬇️
...va/com/iterable/iterableapi/IterableApiClient.java 75.00% <75.00%> (-1.07%) ⬇️
.../com/iterable/iterableapi/IterableRequestTask.java 80.00% <85.71%> (+0.52%) ⬆️
...in/java/com/iterable/iterableapi/IterableUtil.java 70.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ayyanchira Ayyanchira self-requested a review October 16, 2023 20:45
@Ayyanchira Ayyanchira marked this pull request as ready for review October 16, 2023 20:45
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the CI error and also fixes a possible crash scenario when master key is built

@Ayyanchira Ayyanchira merged commit ac7418b into encryption Oct 16, 2023
4 checks passed
@Ayyanchira Ayyanchira deleted the wip/fix-ci branch October 16, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants