Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to download demo on wishlists #1614

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

candela97
Copy link
Collaborator

@candela97 candela97 commented May 2, 2023

Related to #447, perhaps a prerequisite?

This adds a link to download available demos on wishlists next to platform icons. Only visible in expanded view.

TODO

  1. Different color? Now it's the same as the Early Access tag.
  2. Params need to be split into chunks on larger wishlists, which means more requests. Not sure if Steam will be happy with us using this endpoint like this, so the result should be cached somehow.

@candela97 candela97 added the discussion needed Additional discussion required label May 2, 2023
@candela97
Copy link
Collaborator Author

Random thoughts:

  1. The link could be placed in the title to support compact view, but that changes its position due to varying title lengths.
  2. api/appdetails can be used to get demos too, but it does not support filtering to demos with multiple appids.
  3. The ITAD server could compile and store a list of appids with their associated demos. The only problem I can think of is region/age restricted apps (the current endpoint will return nothing, and I assume the demo won't be downloadable anyway), but are pretty rare so probably doesn't matter (you'll have to have added the app prior to it being region/age restricted).
  4. Regarding wishlist filtering, the only way to add custom filters as far as I can tell (and saw used in practice) is to redefine g_Wishlist.BPassesFilters with custom logic. That's a large script to inject (which we've been trying to avoid), and means we'll have to keep it up to date with Steam changes.

@candela97
Copy link
Collaborator Author

candela97 commented Mar 15, 2024

Latest commit implements a cache on fetched appids for 24 hours. This should be an ok feature even without the filtering functionality.

Still considering whether to put the button in the title, sucks to not support compact view.
Probably needs an option too.

@candela97 candela97 marked this pull request as ready for review March 15, 2024 23:38
@tfedor
Copy link
Member

tfedor commented Apr 10, 2024

I'm trying to figure out how useful this feature actually is. If you have added it to your wishlist already, will you need to have a download demo button there? The decision whether you want it has already been made, no?

@candela97
Copy link
Collaborator Author

This has been requested a couple of times over the past few years, e.g. https://steamcommunity.com/discussions/forum/10/3094515496007356620/

People add unreleased games to their wishlist as well, and demos are often added at a later time. There're also time limited demos. In general this is just for convenience so you don't have to visit the store page everytime, and Steam provides a download demo button on sale pages too.

@candela97 candela97 marked this pull request as draft June 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
augmentation New feature or request discussion needed Additional discussion required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants