This repository has been archived by the owner on Aug 1, 2019. It is now read-only.
Added x86 build for loc #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izolyomi
reviewed
Dec 3, 2018
| ENV LOCALPORT 16982 | ||
|
|
||
| # TCP port to serve node to node communication. Optional, default value: 16980 | ||
| #Should only be locally available |
There was a problem hiding this comment.
The comment on local availability is wrong here, it should stand with the LocalPort as its name also clearly states.
|
Thanks for the PR. With my limited docker skills, I could find only a misplaced comment, otherwise looks reasonable as far as I can tell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.