Indicate role using LED eye colors #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good stuff guys! will take a look |
oxkitsune
requested changes
Jul 7, 2023
crates/control/src/led_status.rs
Outdated
| Role::Loser => Eye::loser_eye(), | ||
| Role::Striker => Eye::striker_eye(), | ||
| Role::StrikerSupporter => Eye::striker_support_eye(), | ||
| Role::DefenderLeft | Role::DefenderRight => Eye::defender_eye(), |
There was a problem hiding this comment.
Could we maybe split this up, and split the colours in the eye based on the defender side? Might be useful!
Fyor
requested changes
Jul 7, 2023
crates/control/src/led_status.rs
Outdated
| Role::StrikerSupporter => Eye::striker_support_eye(), | ||
| Role::DefenderLeft | Role::DefenderRight => Eye::defender_eye(), | ||
| Role::Keeper => Eye::keeper_eye(), | ||
| Role::ReplacementKeeper => Eye::keeper_replacement_eye(), |
There was a problem hiding this comment.
Suggested change
| Role::ReplacementKeeper => Eye::keeper_replacement_eye(), | |
| Role::ReplacementKeeper => Eye::replacement_keeper_eye(), |
crates/types/src/led.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn keeper_replacement_eye() -> Eye { |
There was a problem hiding this comment.
Suggested change
| pub fn keeper_replacement_eye() -> Eye { | |
| pub fn replacement_keeper_eye() -> Eye { |
jkbkaiser
reviewed
Jul 7, 2023
crates/types/src/led.rs
Outdated
|
|
||
| pub fn striker_eye() -> Eye { | ||
| Eye { | ||
| color_at_0: Rgb::new(255, 0, 0), |
jkbkaiser
reviewed
Jul 7, 2023
crates/types/src/led.rs
Outdated
|
|
||
| pub fn defender_eye() -> Eye { | ||
| Eye { | ||
| color_at_0: Rgb::new(255, 255, 255), |
jkbkaiser
reviewed
Jul 7, 2023
crates/types/src/led.rs
Outdated
|
|
||
| pub fn keeper_eye() -> Eye { | ||
| Eye { | ||
| color_at_0: Rgb::new(0, 0, 255), |
oxkitsune
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
The NAO's will now change their eye color based on their currently assigned role
Fixes #117
Ideas for Next Iterations (Not This PR)
How to Test
Run code on NAO and force roles using twix