Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify iteration space as static library #1847

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

The "simplify_iteration_space.cpp" was being compiled as source for every pybind11 native extension.

This change compiles it as a static library once, and links the library into pybind11 native extension modules, shaving some build time.

"simplify_iteration_space.cpp" also no longer includes "dpctl4pybind11.hpp", and hence does not need SYCL target enabled, compiling it as ordinary host code.


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Copy link
Collaborator Author

On rather beefy server, the build time improved very slightly, as reported by /usr/bin/time -f "%P %E %M" python scripts/build_locally.py --verbose:

branch CPU utilization Wall-time Peak memory usage
PR branch 1154% 5:32.50 3974668
main branch 1134% 5:42.66 3980596

Copy link

github-actions bot commented Sep 23, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_66 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_67 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Coverage Status

coverage: 87.907%. remained the same
when pulling 3f6af83 on simplify-iteration-space-as-static-library
into 687d66f on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes locally and it works fine. Extensions which leverage simplify_iteration_space also build correctly.

LGTM!

@oleksandr-pavlyk
Copy link
Collaborator Author

Compiled for CUDA target. The test suite run was a PASS.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4d3ddf9 into master Sep 23, 2024
52 of 53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the simplify-iteration-space-as-static-library branch September 23, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants