Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Miniforge3 variant, instead of deprecated Mambaforge #1844

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Use Miniforge3 variant, instead of deprecated Mambaforge #1844

merged 2 commits into from
Sep 19, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Change workflow script conda-package.yaml, to use miniforge-variant: Miniforge3 to address warnings.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_55 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 19, 2024 •
edited
Loading

Coverage Status

coverage: 87.907%. remained the same
when pulling 3759e2f on update-miniforge-variant-to-fix-warning
into 1717b38 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_56 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian
ndgrigorian approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are gone and added to changelog, LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5aa0180 into master Sep 19, 2024
50 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the update-miniforge-variant-to-fix-warning branch September 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian