Add support for pow with inexact base and integer exponent, refactor in-place binary operation type support
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves performance for specific edge cases where the base array is of a floating-point data type and the exponent is 32-bit integer
This makes the code easier to understand
Improves readability of in-place code
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_375 ran successfully. |
6 tasks
|
Superseded by #1815 , which contains the same commits refactoring in-place type support tables, but excludes |
ndgrigorian
deleted the
improve-inplace-binary-ops-new-pow-type-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dedicated kernels to the
powdtype matrix for some cases of a floating-point base and integer exponent.This greatly improves the performance by removing the need to copy and up-cast both arrays.
Also refactors in-place binary operation type support: rather than relying on the out-of-place type support matrix and table, binary in-place operations now have their own dedicated tables. This means that in-place operations can more easily support type combinations which the out-of-place functions don't.