Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

176 descriptor set optimizations under constrained knn query is inefficient #220

Merged
merged 18 commits into from
Oct 2, 2024
Merged

176 descriptor set optimizations under constrained knn query is inefficient #220

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4a89ab6
added index creation calls to low level handler
ifadams Sep 16, 2024
d09fece
Bubbled up index creation call
ifadams Sep 16, 2024
bb140f0
modified descriptor set creation to include index creation, add/find …
ifadams Sep 18, 2024
612d69c
Fixed ID property issue
ifadams Sep 19, 2024
e7e28eb
Automated updates: Format and/or coverage
sys-vdms Sep 19, 2024
9117ef1
Automated updates: Format and/or coverage
sys-vdms Sep 19, 2024
b6ea57f
Automated updates: Format and/or coverage
sys-vdms Sep 19, 2024
c59eab9
tweaks, returning error for knn with _ref
ifadams Sep 25, 2024
bd2e9c6
merge
ifadams Sep 25, 2024
bf82fb0
fixed issue with constraints not getting propagated correctly and upd…
ifadams Sep 25, 2024
2541c59
merge
ifadams Sep 26, 2024
19d20ea
Automated updates: Format and/or coverage
sys-vdms Sep 26, 2024
156744d
Automated updates: Format and/or coverage
sys-vdms Sep 27, 2024
2a7ed7b
Cleaned up some cruft, tweaked index creation methods, added small un…
ifadams Sep 30, 2024
4e4ae1e
Trimming add index test, has dependencies which borks tests internally
ifadams Sep 30, 2024
fcc13c8
Automated updates: Format and/or coverage
sys-vdms Sep 30, 2024
8a9412c
Automated updates: Format and/or coverage
sys-vdms Oct 1, 2024
c566280
Automated updates: Format and/or coverage
sys-vdms Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/coverage/cpp.develop.coverage_report.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ src/BackendNeo4j.cc 121 0 0% 4,6-17,20,24,2
src/BlobCommand.cc 87 66 75% 76,130-132,136-139,145,147,165,186-189,192-196,202
src/BoundingBoxCommand.cc 180 4 2% 45,49,51,53-54,56-59,62,64-67,70-73,76,83,87,90-91,93-97,101,103,105,114,118,122-123,125-132,137-138,140-144,147-150,152,154-160,162-165,167-169,171-173,176-177,179-181,183-184,186-187,190,193,196-197,199,201-204,206-210,213,215-219,222-223,225-227,229-237,240-244,246,251-256,259-261,263,265-266,268,270,272-274,276-277,281-283,286,288,292-294,296,298,300-303,307-308,310-313,316-319,321-326,329-330,335,338-339,341
src/CommunicationManager.cc 46 0 0% 42-43,46-47,49-50,52-54,57,61-66,68-71,73-81,84,86-88,93,96-97,100-101,105,107-108,110,113-116
src/DescriptorsCommand.cc 670 107 16% 56,63-68,73,75-79,81-85,87,89,92-93,96-98,101,103-104,107-113,115,118,121,168-170,174,188-192,232-243,253,267-269,273,288-297,299,311-314,319,324-328,345,353,355-358,361,364-365,367-371,374,377,379-380,383-385,387-388,390-391,394-395,397-399,405,410-411,413,415-416,419,421-424,427-432,438-439,442,444-445,447,449-450,453,456,458,460,463,465-470,472-476,478,481,484-485,488-489,500,503,508,514-515,520-521,523-526,529,535-536,541-542,545-551,554,556-557,559,561-562,564-565,569,571-576,579-584,587,590-595,597,623-624,627-628,631,634,641-642,644-646,648,651-652,654,657,660,662-664,672,676,678,681,683-686,689-694,696-700,702,705,707,709,712,715-716,718,720,722-727,730,732-734,737-738,740,742,744-745,747,749,751-753,755,757-762,767-768,771,773,775,782-783,786,790,792,795,797-800,803-807,809-813,815,817-820,822-824,827,831-840,845-846,849,855,857,860-861,864,868,873,875,878,881-882,886,891,893,895,898,901-902,904-907,911,915-916,918,920-922,924,926-927,929,931-933,935-937,942-944,947-948,950,953-957,961,964,968,970-971,973-974,976,978-979,981-983,985,990,992-993,995-997,999-1000,1004,1006-1009,1011-1014,1019,1022-1024,1026,1028,1030-1033,1035-1039,1042-1043,1046,1048,1050,1052-1056,1059-1060,1063-1066,1068,1070-1077,1082,1084,1086-1087,1090-1093,1095,1097,1099-1106,1110-1115,1121,1124,1126,1128-1131,1134,1136,1139-1142,1144-1148,1154,1156,1158-1161,1166,1168,1170-1171,1174-1176,1178,1180,1182-1185,1188-1189,1191-1192,1194,1196-1197,1199-1205,1209-1210,1214-1215,1217-1218,1226-1227,1230-1231,1233,1235-1242,1246,1250-1251,1255-1259,1264-1265,1267
src/DescriptorsCommand.cc 712 110 15% 56,63-68,73,75-79,81-85,87,89,92-93,96-98,101,103-104,107-113,115,118,121,168-170,174,188-192,243-254,264,272-275,289-291,295,310-319,321,333-336,341,347-351,368,376,378-381,384,387-388,390-394,397,400,402-403,406-408,410-411,413-414,417-418,420-422,428,433-434,436,438-439,442,444-447,450-455,461-462,465,467-468,470,472-473,476,480-481,483,485,488,490-495,497-501,503,506,509-510,513-514,525,528,533,539-540,545-546,548-551,554,560-561,566-567,570-576,579,581-582,584,586-587,589-590,594,596-601,604-609,612,615-618,621-622,624,626,629-630,633-634,637,640,647-648,650-652,654,657-658,660,663,666,668-670,678,682,684,687,689-692,695-700,702-706,708,711,713,715,718,721-722,724,726,728-733,736,738-740,743-744,746,748,750-751,753,755,757-759,761,763-768,773-774,777,779,781,788-789,792,796,798,801,803,805-808,811-815,817-821,823,825-828,830-832,835,839-848,853-854,857,863,865,868-869,872,876,881,883,886,889-890,894,900-904,906,911,914,917-918,920-923,927,931-932,934,936-938,940,942-943,945,947-949,951-953,958-960,963-967,970,973-975,978-980,982,984,989,997-1001,1005,1008,1015-1018,1020-1021,1023,1025-1026,1028-1030,1032,1037,1040-1041,1044-1047,1049-1050,1054,1056-1059,1061-1064,1069,1072-1074,1076,1078,1080,1082,1084-1087,1089-1093,1096-1097,1100,1102,1104,1106-1110,1113-1114,1117-1120,1122,1124-1131,1136,1138,1140-1141,1144-1147,1149,1151,1153-1160,1164-1169,1178,1180,1182-1185,1188,1190,1193-1196,1198-1202,1208,1210,1212-1215,1220,1222,1224-1225,1228-1230,1232-1235,1238-1239,1241-1244,1248-1250,1254,1258,1260-1263,1266-1267,1269-1270,1272,1274-1275,1277-1283,1287-1288,1292-1293,1295-1296,1304-1305,1308-1309,1311,1313-1320,1324,1328-1329,1333-1337,1342-1343,1345
src/DescriptorsManager.cc 24 19 79% 49-50,57-58,73
src/ExceptionsCommand.cc 6 0 0% 35-40
src/ImageCommand.cc 322 157 48% 55,59,63,65,67-69,71,73-76,78,81,86,88-89,97,99,106,109,111-112,114-115,117-118,120-121,124,151,162-163,174-175,177,182-185,195-196,198,203-206,221-229,231-233,246-247,257-267,269-270,272-273,278,286,297,304,308,311,313,315,337,339-340,343-348,350,352,374-376,379-381,385-388,394,396,403-406,420,427,433-436,440-441,452-455,458-463,468-470,481-484,489-493,498-499,501-502,504-508,511,513-517,520-523,526-527,530,532,537
Expand All @@ -20,8 +20,8 @@ src/Neo4jBaseCommands.cc 38 0 0% 7-8,12,14-15,1
src/Neo4JHandlerCommands.cc 109 0 0% 50,54-55,57-58,61,65-69,72,74,76-80,82,84,86,92,95-96,98,100,102,106-107,110-111,114-119,123-124,126,128-129,132-133,137-139,141,144,149-151,155,157,160,162,165-166,169,172,176-178,180-186,188-191,196,198-201,203,206,209,211-213,217-220,222-225,228-231,233-237,239-244,249
src/OpsIOCoordinator.cc 96 73 76% 48,52,54-55,57,61-63,65,74,78,80,91,93,100,102-103,123,125,133,149,153,203
src/PMGDIterators.cc 52 44 84% 62,76,96-101
src/PMGDQuery.cc 463 363 78% 89-92,94-96,129,131,135,140,143-144,167-169,171-172,211-212,216-218,248,254,258,288,298,302-305,307,309,311,317,321-322,354,356,358,360-361,364-373,375-377,379,383-384,386-388,409,412-414,419-424,446,449-450,480-481,492,547,549-557,653-654,658-662,664-668
src/PMGDQueryHandler.cc 623 517 83% 82-84,166-167,169-170,194-197,208-209,230,279,281,285,290,292,320-321,338,340,344,346,397-398,400,402-407,409,411,463-464,478-479,488,490,496,498,524-526,537,566,605,607,612-613,649,651-655,677-679,681-686,688,720,729-730,737,741-743,745,748,751,815,822,850,870-876,878-879,881,883,895-896,915-917,921-922,965,1012-1013,1015-1017
src/PMGDQuery.cc 466 366 78% 89-92,94-96,129,131,135,140,143-144,167-169,171-172,211-212,216-218,248,254,258,288,298,302-305,307,309,311,317,321-322,354,356,358,360-361,364-373,375-377,379,383-384,386-388,409,412-414,419-424,446,449-450,480-481,492,547,549-557,653-654,658-662,664-668
src/PMGDQueryHandler.cc 643 523 81% 82-84,166-167,169-170,194-197,208-209,230,279,281,285,290,292,320-321,338,340,344,346,397-398,400,402-407,409,411,463-464,478-479,488,490,496,498,524-526,537,566,605,607,612-613,649,651-655,677-679,681-686,688,720,729-730,737,741-743,745,748,751,815,822,850,870-876,878-879,881,883,895-896,915-917,921-922,965,1012-1013,1015-1017,1024,1027,1029-1038,1050,1052
src/QueryHandlerBase.cc 32 6 18% 26-29,35-36,38,42-43,45,47-48,52,56-58,60-62,64-66,68-69,72-73
src/QueryHandlerExample.cc 33 18 54% 65-67,75-78,84-85,89-92,94-95
src/QueryHandlerNeo4j.cc 139 0 0% 53,55-56,58,60-62,64-65,67,70-76,80-81,83-87,91,93,95-100,104-108,111-115,119-126,129-132,134-136,139-147,149-153,159,162,169,172-175,177-179,181,184-187,189-190,192,194,197,199,201-204,207-208,210,212-213,216,218,222-223,225,229,231-232,235,237-240,243-247,250-254,256-257,261-268,271-274,277
Expand Down Expand Up @@ -57,5 +57,5 @@ utils/src/comm/Exception.cc 6 0 0% 35-40
utils/src/stats/SystemStats.cc 250 249 99% 453
utils/src/timers/TimerMap.cc 82 75 91% 126,151,153,155-158
------------------------------------------------------------------------------
TOTAL 10172 6513 64%
TOTAL 10237 6525 63%
------------------------------------------------------------------------------
2 changes: 1 addition & 1 deletion .github/coverage/cpp.develop.coverage_value.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
64.0287
63.7394
Loading
Loading