Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address code scanning issues with remote functions and vdms client #205

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

rv355
Copy link
Contributor

@rv355 rv355 commented Aug 8, 2024

No description provided.

Copy link

github-actions bot commented Aug 8, 2024

Target CPP Coverage: 64.3906%
Source CPP Coverage: 64.3906%

Target Python Coverage: 98%
Source Python Coverage: 98.02%

Copy link

github-actions bot commented Aug 8, 2024

Target CPP Coverage: 64.3906%
Source CPP Coverage: 64.3807%

Target Python Coverage: 98%
Source Python Coverage: 98.02%

Copy link

github-actions bot commented Aug 8, 2024

Target CPP Coverage: 64.3906%
Source CPP Coverage: 64.4006%

Target Python Coverage: 98%
Source Python Coverage: 98.02%

Copy link

github-actions bot commented Aug 8, 2024

Target CPP Coverage: 64.3906%
Source CPP Coverage: 64.3906%

Target Python Coverage: 98%
Source Python Coverage: 98.02%

Copy link

github-actions bot commented Aug 9, 2024

Target CPP Coverage: 64.3906%
Source CPP Coverage: 64.3906%

Target Python Coverage: 98%
Source Python Coverage: 98.02%

Copy link
Contributor

@ifadams ifadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern is if we have any additional 3rd party libs included to make sure that we're correctly scanned, no licensing issues, requirements docs/installs updated....

Copy link
Contributor

@ifadams ifadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues to address that I see.

@s-gobriel s-gobriel merged commit 0ea1717 into develop Aug 15, 2024
9 checks passed
@cwlacewe cwlacewe added this to the v2.10.0 Tasks milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants