Add trace observer/feedback + Rocket and Spike support #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| OpLog::RegOp(RegOp{op_type: OpType::Read, name: caps[3].to_string(), value: u64::from_str_radix(&caps[4], 16).unwrap()}) | ||
| ]; | ||
|
|
||
| if caps.get(5) != None && &caps[6] == "mem" { |
Check warning
Code scanning / clippy
binary comparison to literal `Option::None`
|
|
||
| if caps.get(5) != None && &caps[6] == "mem" { | ||
| ops.push(OpLog::MemOp(MemOp{op_type: OpType::Read, address: u64::from_str_radix(&caps[7], 16).unwrap(), value: u64::from_str_radix(&caps[4], 16).unwrap()})); | ||
| } else if caps.get(5) != None { |
Check warning
Code scanning / clippy
binary comparison to literal `Option::None`
| if core_observer.cnt() == ref_observer.cnt() { | ||
| return Ok(false); | ||
| } | ||
| return Ok(true); |
Check warning
Code scanning / clippy
unneeded `return` statement
|
Thanks for the contribution! Except the 3 warnings from Clippy it looks all good to me |
Bounti
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, we added support for parsing and involving execution traces as an observer and feedback.