Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register and Login page responsive #462

Merged
merged 11 commits into from
Jun 22, 2024

Conversation

the-t3ch-wizard
Copy link
Contributor

@the-t3ch-wizard the-t3ch-wizard commented Jun 5, 2024

Description

Removed some unnecessary code from UserRegistration page.
Made Register and Login page responsive.

Fixes #450 , #419 and #380

Related Issue

None

Screenshots / GIFs (if applicable)

Screenshot 2024-06-05 144802
Screenshot 2024-06-05 144751

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

Additional Notes

None

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@rishicds
Copy link
Collaborator

rishicds commented Jun 5, 2024

fix conflicts @the-t3ch-wizard

@codewarnab
Copy link
Collaborator

Description

Removed some unnecessary code from UserRegistration page. Made Register and Login page responsive.

Fixes #450 , #419 and #380

Related Issue

None

Screenshots / GIFs (if applicable)

Screenshot 2024-06-05 144802 Screenshot 2024-06-05 144751

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

Additional Notes

None

hey you did good job are you contributing under gssoc ?

@codewarnab
Copy link
Collaborator

image
make the create account text little bit more smaller
image
decrease this padding from all sides probabalu this will fit the create account text in one line which will look better

src/pages/user/UserRegistration.jsx Show resolved Hide resolved
src/pages/user/UserRegistration.jsx Show resolved Hide resolved
src/pages/user/UserRegistration.jsx Outdated Show resolved Hide resolved
src/pages/user/UserRegistration.jsx Outdated Show resolved Hide resolved
@the-t3ch-wizard
Copy link
Contributor Author

I'm working on the conflicts and will inform as soon as possible.

@the-t3ch-wizard
Copy link
Contributor Author

@codewarnab Please review my PR.
I have improved the ui as requested.
and since you asked, no i'm not contributing under gssoc

src/pages/user/HomePage.jsx Outdated Show resolved Hide resolved
src/pages/user/UserRegistration.jsx Outdated Show resolved Hide resolved
@codewarnab
Copy link
Collaborator

image make the create account text little bit more smaller image decrease this padding from all sides probabalu this will fit the create account text in one line which will look better

also did you chanages this what i mentioned ?

@the-t3ch-wizard
Copy link
Contributor Author

the-t3ch-wizard commented Jun 6, 2024

image make the create account text little bit more smaller image decrease this padding from all sides probabalu this will fit the create account text in one line which will look better

also did you chanages this what i mentioned ?

Yes I have improved the ui as requested
The mobile ui :
Screenshot 2024-06-06 214828
The tablet ui :
Screenshot 2024-06-06 221706

@the-t3ch-wizard
Copy link
Contributor Author

@codewarnab is there something more that is required to be done here?

@codewarnab
Copy link
Collaborator

@codewarnab is there something more that is required to be done here?

no its ok i will merge soon after reviewing ,i am little busy with my exams ...

@codewarnab
Copy link
Collaborator

good job

@codewarnab codewarnab merged commit dbc2c4b into Innovateninjas:main Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness of the register page on all devices💡[FEATURE]:
3 participants