Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Design of Home Page #379

Merged
merged 3 commits into from
May 23, 2024
Merged

Responsive Design of Home Page #379

merged 3 commits into from
May 23, 2024

Conversation

riya-rjha
Copy link
Contributor

@riya-rjha riya-rjha commented May 21, 2024

I have added a max height of the container which is thus disallowing the footer underneath to cover up the buttons. As and when the height resizes, the footer changes.
Here's the final look in the desktop view:
Screenshot (27)

#319 issue resolved

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@codewarnab
Copy link
Collaborator

@riya-rjha good job will be merged soon

@codewarnab codewarnab requested a review from rishicds May 22, 2024 17:40
@codewarnab
Copy link
Collaborator

@riya-rjha wait before merging can you please add a screenshot of the mobile screen ?

@riya-rjha
Copy link
Contributor Author

image
Screenshot (34)

Here are the two screenshots, for mobile screens it is working well, but when the height reduces till 660 pixels, the button overlaps the content.

@codewarnab
Copy link
Collaborator

Approved ! @rishicds

@rishicds rishicds merged commit 498b3a1 into Innovateninjas:main May 23, 2024
@codewarnab codewarnab added level1 10 points gssoc Girl Script Summer of Code labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level1 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants