Password must be strong with specific rules issue#337 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
please mention related issue |
Done |
|
Hi @kapilG0 , please update your branch |
codewarnab
requested changes
May 17, 2024
There was a problem hiding this comment.
@kapilG0 sync your branch resolve conflicts then commit again
src/pages/user/UserRegistration.jsx
Outdated
| onClick={async () => | ||
| registration( | ||
| name, | ||
| phone_number, | ||
| email, | ||
| password, | ||
| setError, | ||
| setErrorMessage, |
There was a problem hiding this comment.
why did you passed this setErrorMessage in this registartion function ?
Hello @codewarnab I raised new pull request #351. Please check after sync my forked repo. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now Register button is disabled if password is not good
Related Issue
#337
Screenshots / GIFs (if applicable)
[Attach any relevant screenshots or GIFs demonstrating the changes]
Checklist:
Additional Notes
[Add any additional notes or context about the changes made]