Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#252 improve from UI #315

Merged
merged 4 commits into from
May 17, 2024
Merged

#252 improve from UI #315

merged 4 commits into from
May 17, 2024

Conversation

Priyal208
Copy link
Contributor

@Priyal208 Priyal208 commented May 13, 2024

Description

I enhanced the look and feel of UI , as promised I made UI more appealing and beautiful made it look more professional. The older one was plain blank and basic. Here I have attached screenshots of how it looked earlier and how i completely changed it.

Related Issue

Assigned to me under #252

Screenshots / GIFs (if applicable)

before-
Screenshot 2024-05-13 204147
after-
Screenshot 2024-05-13 205810
Screenshot 2024-05-13 205819

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

Additional Notes

[Add any additional notes or context about the changes made]

@Priyal208
Copy link
Contributor Author

@codewarnab Kindly review this!

@rishicds
Copy link
Collaborator

image

Hey @Priyal208 , please make the page responsive

@codewarnab
Copy link
Collaborator

codewarnab commented May 16, 2024

image

Hey @Priyal208 , please make the page responsive

no need merge it for responsiveness #261
approved from my side fix the merge conflicts and good to go @Priyal208

@codewarnab
Copy link
Collaborator

@Priyal208 looks like you havnt updated your branch for long please update your branch asap

@Priyal208
Copy link
Contributor Author

image
Hey @Priyal208 , please make the page responsive

no need merge it for responsiveness #261 approved from my side fix the merge conflicts and good to go @Priyal208

okay sure

@Priyal208
Copy link
Contributor Author

Priyal208 commented May 17, 2024

@codewarnab now pls check i have done so! I have made it up to date and all changes are forked, now kindy review it!

@Priyal208 looks like you havnt updated your branch for long please update your branch asap

Copy link
Collaborator

@rishicds rishicds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rishicds rishicds merged commit 1bf94fb into Innovateninjas:main May 17, 2024
1 check passed
@rishicds rishicds added level1 10 points gssoc Girl Script Summer of Code labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level1 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants