Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] : Implement the Button animation and transition #310

Conversation

sivaprasath2004
Copy link

Description

#293 feature can be added..

Related Issue

New Feature like button transition and button box-shadow and hover

Screenshots / GIFs (if applicable)

Screencast.from.2024-05-13.16-45-31.webm

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

@sivaprasath2004
Copy link
Author

@codewarnab I will finish it..... 🚀

@rishicds rishicds added level1 10 points gssoc Girl Script Summer of Code labels May 16, 2024
@rishicds
Copy link
Collaborator

Hi @sivaprasath2004 , please fix the conflicts , also if possible change the color of the button to green and make the animation less intrusive so it matches the theme, otherwise its good

@sivaprasath2004
Copy link
Author

@rishicds i will finished it..

@codewarnab
Copy link
Collaborator

codewarnab commented May 16, 2024

@sivaprasath2004 add the latest scrrenshot ( if you have updated ). btw button colour should be green add some subtle animation not much animation needed .

@sivaprasath2004
Copy link
Author

@codewarnab I will finish it..

Screencast.from.2024-05-16.19-06-51.webm

@codewarnab
Copy link
Collaborator

@sivaprasath2004 it looks good but you have used lots of external css we encourage using tailwind css try to chanage those as much in tailwind you can we :)
also whats in the app.css do ? their is already a button.css is their , and share a gif showing that reactivity of the button is same as before which shows waiting, loggin in etc during the login and registration . Thank you

@sivaprasath2004
Copy link
Author

Hello @codewarnab I can try to change tailwind css but that cannot expected work that is inproper so i suggest external css that is proper work please proceed or change to the another model button animation.

@codewarnab
Copy link
Collaborator

Hello @codewarnab I can try to change tailwind css but that cannot expected work that is inproper so i suggest external css that is proper work please proceed or change to the another model button animation.

you didnt answered another question what the styles in app.css do ?
we dont prefer writing styles in app.css until its used in many files

@codewarnab
Copy link
Collaborator

@sivaprasath2004 reply asap else we have to close this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level1 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants