Prevent escape keypress from emptying the editor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 13, 2019 12:00
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
…ovation-funding-service into development
Pressing the escape key whilst editing clears the text area. This prevents that from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst writing applications or assessment feedback, if you press the escape key, the text editor is cleared and there's no way to retrieve the text that you've just written.
This is incredibly frustrating, especially as an assessor where your feedback is lost with no way to retrieve it, and you have to redo that section's assessment again.
This patch prevents the escape key from clearing the editor's content, as discussed in this issue #17
The problem is a known issue with
hallo.jsand has also been reported upstream.