Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RebasingComponentModule with FlashMintWrapped integration tests #184

Merged
merged 27 commits into from
Sep 18, 2024
Merged

Add RebasingComponentModule with FlashMintWrapped integration tests #184

merged 27 commits into from
Sep 18, 2024

Conversation

pblivin0x
Copy link
Contributor

No description provided.

@pblivin0x
add TargetWrapExtension
2e7e337
@pblivin0x
refactor TargetWeightWrapExtension:
c9de689
@pblivin0x
add updated issuance dependencies
c17a9eb
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
852b2b4
@pblivin0x
update setV2 fixture
4c49951
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
288f093
@pblivin0x
update setValuer in tests
a419209
@pblivin0x
use nav issuance
af43944
@pblivin0x
reorder declarations
252de4a
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
05d3120
@pblivin0x
cleanup contract, add unit tests
d580bca
@pblivin0x
Merge branch 'master' into target-wrap-extension
2cc7c56
@pblivin0x
update ether reserve logic
d1f0432
@pblivin0x
add valuation tests
0a410b3
@pblivin0x
update rebalancer check
036cff5
@pblivin0x
update wrap dependencies for integration testing
6c7aff8
@pblivin0x
refactor isRebalancing, integration testing setup
f46d53f
@pblivin0x
remove extra reserve check, add aave v2 wrap adapter
33a10cc
@pblivin0x
add wrapData, remove ether functionality, patch tests
755dbbf
@pblivin0x
add cleanups
cdf3ead
@pblivin0x
remove diff
c23238f
@pblivin0x
remove keeper view function
01216fe
@pblivin0x
add extrema cases
4269d1e
@pblivin0x
add rebasing FlashMintWrapped integration tests
8a30f31
@pblivin0x
add all assets
a22dfd9
@pblivin0x pblivin0x marked this pull request as ready for review September 3, 2024 22:31
Base automatically changed from target-wrap-extension to master September 4, 2024 16:47
edkim
edkim approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@edkim edkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could be helpful to add tests for issuing from / redeeming to another currency, but leave that up to you 😄

@pblivin0x pblivin0x merged commit 509df42 into master Sep 18, 2024
5 checks passed
@pblivin0x pblivin0x deleted the rebasing-flashmint-wrapped branch September 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edkim edkim edkim approved these changes

@janndriessen janndriessen Awaiting requested review from janndriessen

@0xonramp 0xonramp Awaiting requested review from 0xonramp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pblivin0x @edkim