-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extension): Add support for alternative Flashloan providers to migration extension #167
feat(extension): Add support for alternative Flashloan providers to migration extension #167
Conversation
import { IMorpho } from "../interfaces/IMorpho.sol"; | ||
import { IBalancerVault } from "../interfaces/IBalancerVault.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sort with aave and uniswap imports
uint256[] memory feeAmounts, | ||
bytes memory params | ||
) external { | ||
require(msg.sender == address(BALANCER)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -363,7 +363,7 @@ if (process.env.INTEGRATIONTEST) { | |||
isUnderlyingToken0 = true; | |||
|
|||
// Subsidize 0.01 WBTC to the migration extension | |||
maxSubsidy = bitcoin(0.01); | |||
maxSubsidy = bitcoin(0.00); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@@ -342,7 +342,7 @@ if (process.env.INTEGRATIONTEST) { | |||
aEthWeth.address, | |||
); | |||
const wrappedExchangeRate = preciseDiv(ether(1), wrappedPositionUnits); | |||
maxSubsidy = ether(3.205); | |||
maxSubsidy = ether(0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
added some comments on optional cleanups
No description provided.