Save ipfs rules string instead of bytes32 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
changed the title
pblivin0x
reviewed
Jan 11, 2024
| @@ -99,7 +99,7 @@ contract OptimisticAuctionRebalanceExtensionV1 is AuctionRebalanceExtension, As | |||
|
|
|||
| struct ProductSettings{ | |||
| OptimisticRebalanceParams optimisticParams; // OptimisticRebalanceParams struct containing optimistic rebalance parameters. | |||
| bytes32 rulesHash; // IPFS hash of the rules for the product. | |||
| string rules; // Definition of rules for the product. (including ipfs hash pointing to full rules) | |||
There was a problem hiding this comment.
pblivin0x
reviewed
Jan 11, 2024
| const claim = assertEvent.args._claimData; | ||
| expect(claim).to.eq(constructClaim()); | ||
| expect(utils.toUtf8String(claim)).to.eq(constructClaim()); |
There was a problem hiding this comment.
Confirming this returns as natural language now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While increasing gas costs, this makes decoding the whole claim a lot easier and fulfils the requirement of
ASSERT_TRUTHclaims to be utf8 decodable.It also adds flexibility by potentially extending the saved string beyond the hash itself to include some instructions such as: "Rules are stored on ipfs under hash: ...."