Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): Add OptimisticAuctionRebalanceExtension #156

Merged
merged 38 commits into from
Jan 9, 2024

Conversation

ckoopmann
Copy link
Collaborator

No description provided.

@ckoopmann ckoopmann marked this pull request as draft December 7, 2023 06:38
@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 77.572% (+30.7%) from 46.877%
when pulling 8ce942f on ckoopmann/optimistic-auction-rebalance-extension
into d5ab030 on master.

@ckoopmann ckoopmann marked this pull request as ready for review December 11, 2023 07:20
@pblivin0x pblivin0x requested a review from edkim December 14, 2023 13:14
@pblivin0x pblivin0x changed the title BaseOptimisticRebalanceAuctionModule for use with the BaseManager in existing products feat(extension): Add OptimisticAuctionRebalanceExtension Dec 15, 2023
ckoopmann and others added 10 commits January 3, 2024 12:45
* Add events for updating the isOpen parameter

* lintoor

* remove .only()

* lintoor

* fix AssetAllowList nits

* Run only new integration tests

* Fix unittests

* Add tests for require statements in proposeRebalance

* Add tests for emitted events

* Extend event emission test

* Adjust integration test to use index token as proposer collateral (currently failing)

* integration test test

* cleanups

* edit integration tests

* Test bond transfer and claim construction

* Fix unittest

---------

Co-authored-by: ckoopmann <[email protected]>
…thub.com:IndexCoop/index-coop-smart-contracts into ckoopmann/optimistic-auction-rebalance-extension
@pblivin0x pblivin0x self-requested a review January 4, 2024 18:54
Copy link
Contributor

@pblivin0x pblivin0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

We may want to peek the flaky optimism integration test

@ckoopmann
Copy link
Collaborator Author

LGTM 💯

We may want to peek the flaky optimism integration test

Seems to be an issue on alchemy side for the optimism rpc.
Let's keep an eye on it. Not much we can do about it though beyond considering an alternative rpc provider.

@pblivin0x pblivin0x merged commit 3fc56f4 into master Jan 9, 2024
9 checks passed
@pblivin0x pblivin0x deleted the ckoopmann/optimistic-auction-rebalance-extension branch January 9, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants