Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Manager): Add DelegatedManager System #150

Merged
merged 10 commits into from
Sep 8, 2023
Merged

feat(Manager): Add DelegatedManager System #150

merged 10 commits into from
Sep 8, 2023

Conversation

pblivin0x
Copy link
Contributor

@pblivin0x pblivin0x commented Aug 25, 2023 •
edited
Loading

Proposals

Contracts

  • Core
    • ManagerCore
    • DelegatedManagerFactory
    • DelegatedManager
  • Global Extensions
    • GlobalBatchTradeExtension
    • GlobalClaimExtension
    • GlobalIssuanceExtension
    • GlobalStreamingFeeSplitExtension
    • GlobalTradeExtension
    • GlobalWrapExtension
  • Library
    • MutualUpgradeV2

@coveralls
Copy link

coveralls commented Aug 25, 2023 •
edited
Loading

Coverage Status

coverage: 77.128% (+0.7%) from 76.388% when pulling 81e86c9 on pblivin0x/delegated-manager-system into 3c0ffba on master.

FlattestWhite
FlattestWhite approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@FlattestWhite FlattestWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming it's a straight copy paste from set-v2-strategies

edkim
edkim approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@edkim edkim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! There's a failing integration test but I don't know if that's even related to this PR.

@pblivin0x pblivin0x marked this pull request as ready for review September 8, 2023 18:56
@pblivin0x pblivin0x merged commit 13aaa83 into master Sep 8, 2023
9 checks passed
@pblivin0x pblivin0x deleted the pblivin0x/delegated-manager-system branch September 8, 2023 22:24
@FlattestWhite
Copy link
Contributor

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edkim edkim edkim approved these changes

@FlattestWhite FlattestWhite FlattestWhite approved these changes

@anthonymbowman anthonymbowman Awaiting requested review from anthonymbowman

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pblivin0x @coveralls @FlattestWhite @edkim