Fix failing tests for AaveV3LeverageStrategyExtension #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
changed the base branch from
master
to
snake-poison/aave-v3-leverage-post-deployment-updates
snake-poison
merged commit d274ec1
into
snake-poison/aave-v3-leverage-post-deployment-updates
ckoopmann
added a commit
that referenced
this pull request
Aug 14, 2023
* remove test filter on FlashMintLeveraged. * chore: update current block * test: updates to deployment of leverage module. * Fix failing tests for AaveV3LeverageStrategyExtension (#147) * Fix failing tests * Adjust test message for ripcord test --------- Co-authored-by: christn <[email protected]>
snake-poison
added a commit
that referenced
this pull request
Aug 14, 2023
* Test showing that settting Emode does not affect getReserveConfigurationData * Start adjusting StrategyExtension test to switcht to wsteth/eth pair * Fixing tests * Fix test * First test case for rebalancing in e-mode * Fix handling of emode ltv / liquidationThreshold * Add test case for wrong repay threshold * Fix tests * Remove subtraction of unutilizedLeveragePercentage when delevering * Add test for targetLeverageRatio verification * Add verification step for targetLeverageRatio >= 1 * Switch div / mul order in _calculateMinRepayUnits * Switch div / mul order in calculateChunkRebalanceNotional * Switch to latestRoundData on chainlink call * Add check for maximum oracle price age * Add tests for outdated price response from oracle * Fix tests * Add method to override noRebalanceInProgress modifier * Fix tests * Use AaveOracle instead of configured chainlink oracles * Get AaveOracle address from AddressProvider instead of deploy argument * Change to get aaveOracle address on the fly from addressProvider * Clean up and additional code comments * fix(dependencies): Add post audit Aave V3 dependencies (#145) update post audit contracts for integration tests Co-authored-by: Pranav Bhardwaj <[email protected]> * Updates to test (#146) * remove test filter on FlashMintLeveraged. * chore: update current block * test: updates to deployment of leverage module. * Fix failing tests for AaveV3LeverageStrategyExtension (#147) * Fix failing tests * Adjust test message for ripcord test --------- Co-authored-by: christn <[email protected]> * remove .only from test * test: fix issues with updating block. Made deadline on uniswap router swaps less brittle. --------- Co-authored-by: pblivin0x <[email protected]> Co-authored-by: Pranav Bhardwaj <[email protected]> Co-authored-by: SnakePoison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.