Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extension): Add AuctionRebalanceExtension #144

Merged
merged 3 commits into from
Aug 18, 2023
Merged

feat(extension): Add AuctionRebalanceExtension #144

merged 3 commits into from
Aug 18, 2023

Conversation

pblivin0x
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 28, 2023 •
edited
Loading

Coverage Status

coverage: 76.388% (+0.1%) from 76.259% when pulling dc3a732 on pblivin0x/auction-extension into 252fa0a on master.

@pblivin0x pblivin0x marked this pull request as ready for review July 28, 2023 23:28
snake-poison
snake-poison reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@snake-poison snake-poison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started reviewing, want to run through the tests before approving but looks good at a glance.

contracts/adapters/AuctionRebalanceExtension.sol Show resolved Hide resolved
external/contracts/set/AuctionRebalanceModuleV1.sol Outdated Show resolved Hide resolved
external/contracts/set/ConstantPriceAdapter.sol Show resolved Hide resolved
external/contracts/set/ConstantPriceAdapter.sol Show resolved Hide resolved
snake-poison
snake-poison approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@snake-poison snake-poison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pblivin0x pblivin0x merged commit 3c0ffba into master Aug 18, 2023
2 checks passed
@pblivin0x pblivin0x deleted the pblivin0x/auction-extension branch August 18, 2023 00:44
@FlattestWhite
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake-poison snake-poison snake-poison approved these changes

@FlattestWhite FlattestWhite FlattestWhite approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pblivin0x @coveralls @FlattestWhite @snake-poison