FlashMintLeveraged #143
Merged
FlashMintLeveraged #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IssuanceLeveragedIntegration test.
… FlashMintContract.
adds relevant addresses to constants. removes balancer specific entrypoint to contract.
FlattestWhite
approved these changes
Jul 15, 2023
ckoopmann
approved these changes
Jul 17, 2023
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on exchangeIssuanceLeveraged
check diff here: https://www.diffchecker.com/p2JuLunt/
Most interesting bit is the following:
a state variable
flashLoanBenefactoris used in conjuction to a guard on receiveFlashLoan to ensure that some external account doesn't initiate a flashloan against this contract and abuse approvals.aave flashloans didn't require this as part of the callback as those loans forward the address of the loan's initiator.