Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to throw exception in non-interactive mode if some params are missing #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fduch
Copy link

@fduch fduch commented Sep 8, 2014

This PR covers #63 and provides new exception-if-missing configuration option.

By default the behavior of script handler is the same as current. But when exception-if-missing option is set to true ParameterHandler will throw an exception when some parameters are missing. This is very useful during build/deploy process (executed for example on build/ci servers) when it is needed only to validate parameters.yml file before installing the application and abort the process when something went wrong, but not to change it's original content in any way.

This behavior affects only non-interactive mode.

@fduch
Copy link
Author

fduch commented Sep 15, 2014

@stof any chance that this PR would be reviewed?

@fduch fduch force-pushed the exception-if-missing branch 2 times, most recently from 9122b11 to d662982 Compare September 19, 2014 06:18
fduch added a commit to fduch/ParameterHandler that referenced this pull request Sep 19, 2014
* exception-if-missing:
  add setting to throw exception in non-interactive mode if some params are missing
@ZeeCoder
Copy link

+1 for such a functionality

@fduch
Copy link
Author

fduch commented May 14, 2015

@ZeeCoder since @stof didn't give any feedback to this PR i use exception-if-missing branch in my fork of the official repository without any issues for almost a year.. :)

@ZeeCoder
Copy link

@fduch Nice.
Actually I don't even get how others do deployment without something like this.
Well, I solved it a way too, but I still don't get how it doesn't seem to be a big issue for others.

I think this feature is needed. 👍

Any opinion on the matter @stof ?

@andrerom
Copy link

+1 , but:

Actually I don't even get how others do deployment without something like this.

Manage fine without this making sure params have sensible defaults.
A bigger problem is how verbose install is starting to become by relying only on ParameterHandler for human installer input.

@alanpoulain
Copy link

+1 Merging this PR would solve a lot of issues we have with our continuous integration.

@Restless-ET
Copy link

👍

@JonasHaouzi
Copy link

@stof Can we help you reviewing this PR? It'd be indeed really helpful. Thanks.

@fduch fduch force-pushed the exception-if-missing branch 2 times, most recently from debbb26 to d662982 Compare May 15, 2018 08:53
@sandermarechal
Copy link

Any progress on this? @stof can this be added instead of #107? This is something I could really use in continuous deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants